[RFR] [CR] [TA] Adapt source analysis test #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Brugarolas <[email protected]>
Signed-off-by: Alejandro Brugarolas <[email protected]>
|
Looks good @abrugaro . We will need to validate on new reports but for now this is good for change adaptation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Tackle version will change how reports are displayed to the user, focusing more on multiple-analyses trends and general issues rather than specific reports for each applications.
The old reports are hidden right now (Tackle2-ui PR 891), that's why I removed the validations from the code. Later we may add them if the reports are available again or automate the new dynamic reports feature.
Jenkins job #382 passed.
I also used this PR to refactor some code and remove some other unused code.
@sshveta could you please review this PR? Thanks