[RFR] [JF] Fix application field validation #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nandini Chandra <[email protected]>
Signed-off-by: Nandini Chandra <[email protected]>
Signed-off-by: Nandini Chandra <[email protected]>
Signed-off-by: Nandini Chandra <[email protected]>
|
This fixes the "Application field validations" test. Results: 3 of 4 passed I will submit a follow up PR to fix the other failure. |
nachandr
changed the title
Signed-off-by: Nandini Chandra <[email protected]>
nachandr
changed the title
sshveta
requested changes
Aug 24, 2023
cypress/e2e/tests/migration/applicationinventory/assessment/create.test.ts
Outdated
Show resolved
Hide resolved
cypress/e2e/tests/migration/applicationinventory/assessment/create.test.ts
Show resolved
Hide resolved
Signed-off-by: Nandini Chandra <[email protected]>
nachandr
force-pushed
the
app_field_validation
branch
from
9228b42
to
1b46fe9
Compare
sshveta
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the "Application field validations" test from the /assessment/create.test.ts spec file.