🐛 Don't use "mvn://::" for an empty binary source in applications (#2015

) When creating an application, if the "Binary (Java)" source is not specified, we want to store an empty string as the `binary` value and not `"mvn://::`. This also applied to editing an existing application. Resolves: #2014 Resolves: https://issues.redhat.com/browse/MTA-3238 Signed-off-by: Scott J Dickerson <[email protected]>
konveyor · Jul 15, 2024 · 646d3d6 · 646d3d6
1 parent 8ddf4f1
commit 646d3d6
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/client/src/app/pages/applications/components/application-form/application-form.tsx b/client/src/app/pages/applications/components/application-form/application-form.tsx
@@ -263,12 +263,12 @@ export const useApplicationFormHook = ({
   });
 
   const onValidSubmit = (formValues: FormValues) => {
-    let binaryValue = formValues.packaging
-      ? `${formValues.group}:${formValues.artifact}:${formValues.version}:${formValues.packaging}`
-      : `${formValues.group}:${formValues.artifact}:${formValues.version}`;
-    if (!binaryValue.startsWith("mvn://")) {
-      binaryValue = `mvn://${binaryValue}`;
-    }
+    const binaryValues = [
+      formValues.group,
+      formValues.artifact,
+      formValues.version,
+      formValues.packaging,
+    ].filter(Boolean);
 
     const payload: New<Application> = {
       name: formValues.name.trim(),
@@ -294,7 +294,8 @@ export const useApplicationFormHook = ({
             path: formValues.rootPath.trim(),
           }
         : undefined,
-      binary: binaryValue,
+      binary:
+        binaryValues.length > 0 ? `mvn://${binaryValues.join(":")}` : undefined,
 
       // Values not editable on the form but still need to be passed through
       identities: application?.identities ?? undefined,