✨ Refactor useFetchTasks()'s select function #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I submitted this PR mostly because I did the refactor when working on the other PR and didn't want to throw it out. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1216 +/- ##
==========================================
+ Coverage 44.04% 44.09% +0.04%
==========================================
Files 177 177
Lines 4516 4511 -5
Branches 1007 1006 -1
==========================================
Hits 1989 1989
+ Misses 2516 2511 -5
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
ibolton336
approved these changes
Jul 27, 2023
sjd78
force-pushed
the
useFetchTasks-better-select
branch
2 times, most recently
from
e26a3bc
to
69b79f4
Compare
sjd78
force-pushed
the
useFetchTasks-better-select
branch
from
69b79f4
to
a26fee5
Compare
The function used by `useFetchTasks()` to filter by addon and to keep only the newest tasks per application id was confusing to read as written. This refactor simplifies the steps involved to use a typical stream processing approach. The output is functionally identical to the original implementation. Signed-off-by: Scott J Dickerson <[email protected]>
sjd78
force-pushed
the
useFetchTasks-better-select
branch
from
a26fee5
to
1a24ca0
Compare
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this refactoring came while working on #1191 and trying to understand what tasks were given to the analysis table. The select function used by
useFetchTasks()to filter by addon and to keep only the newest tasks per application id was confusing to read as written. This refactor simplifies the steps involved to use a typical stream processing approach.Output of the refactored function is functionally identical to the original implementation.