Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add url filter to drawer results for dependency apps #1698

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 commented Feb 22, 2024

@ibolton336 ibolton336 force-pushed the mta-2008-2 branch 2 times, most recently from 28d6c01 to 787f01f Compare February 22, 2024 20:31
Make sure filters are clearable when used as initial values from url

Signed-off-by: Ian Bolton <[email protected]>
@ibolton336 ibolton336 added the cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch. label Feb 22, 2024
Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing to request changes to figure out what the ui test failure is about.

Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, re-run UI tests (I have seen similar temporary install error this morning, worked on 2nd attempt)

@ibolton336 ibolton336 merged commit d07b30d into konveyor:main Feb 26, 2024
7 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 26, 2024
ibolton336 added a commit that referenced this pull request Feb 26, 2024
Resolves https://issues.redhat.com/browse/MTA-2008
&&
#1498

Signed-off-by: Ian Bolton <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>

Signed-off-by: Ian Bolton <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
Co-authored-by: Ian Bolton <[email protected]>
@ibolton336 ibolton336 deleted the mta-2008-2 branch February 26, 2024 18:53
rszwajko added a commit that referenced this pull request Jul 31, 2024
Fix regression after: #1980
Resolves: https://issues.redhat.com/browse/MTA-1390

Initial filter values work best if the table is not persisting state
between reloads (default strategy, component state). If the table uses
session or local storage then any existing filter overwrites the default
value. From the end user perspective the functionality works only on the
first load with a clean browser (no previous state).

Switching to URL filter persistence provides the same functionality and
ensures we have only one source of filters.

Reference-Url:  #1698

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
rszwajko added a commit to rszwajko/tackle2-ui that referenced this pull request Aug 1, 2024
Fix regression after: konveyor#1980
Resolves: https://issues.redhat.com/browse/MTA-1390

Initial filter values work best if the table is not persisting state
between reloads (default strategy, component state). If the table uses
session or local storage then any existing filter overwrites the default
value. From the end user perspective the functionality works only on the
first load with a clean browser (no previous state).

Switching to URL filter persistence provides the same functionality and
ensures we have only one source of filters.

Reference-Url:  konveyor#1698

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
sjd78 pushed a commit that referenced this pull request Aug 1, 2024
#2033) (#2038)

Backport-of:  (#2033)
Fix regression after: #1980
Resolves: https://issues.redhat.com/browse/MTA-1390

Initial filter values work best if the table is not persisting state
between reloads (default strategy, component state). If the table uses
session or local storage then any existing filter overwrites the default
value. From the end user perspective the functionality works only on the
first load with a clean browser (no previous state).

Switching to URL filter persistence provides the same functionality and
ensures we have only one source of filters.

Reference-Url:  #1698

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants