-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add url filter to drawer results for dependency apps #1698
Conversation
28d6c01
to
787f01f
Compare
Make sure filters are clearable when used as initial values from url Signed-off-by: Ian Bolton <[email protected]>
787f01f
to
3ee066c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing to request changes to figure out what the ui test failure is about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, re-run UI tests (I have seen similar temporary install error this morning, worked on 2nd attempt)
Resolves https://issues.redhat.com/browse/MTA-2008 && #1498 Signed-off-by: Ian Bolton <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
Resolves https://issues.redhat.com/browse/MTA-2008 && #1498 Signed-off-by: Ian Bolton <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Signed-off-by: Ian Bolton <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Co-authored-by: Ian Bolton <[email protected]>
Fix regression after: #1980 Resolves: https://issues.redhat.com/browse/MTA-1390 Initial filter values work best if the table is not persisting state between reloads (default strategy, component state). If the table uses session or local storage then any existing filter overwrites the default value. From the end user perspective the functionality works only on the first load with a clean browser (no previous state). Switching to URL filter persistence provides the same functionality and ensures we have only one source of filters. Reference-Url: #1698 Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Fix regression after: konveyor#1980 Resolves: https://issues.redhat.com/browse/MTA-1390 Initial filter values work best if the table is not persisting state between reloads (default strategy, component state). If the table uses session or local storage then any existing filter overwrites the default value. From the end user perspective the functionality works only on the first load with a clean browser (no previous state). Switching to URL filter persistence provides the same functionality and ensures we have only one source of filters. Reference-Url: konveyor#1698 Signed-off-by: Radoslaw Szwajkowski <[email protected]>
#2033) (#2038) Backport-of: (#2033) Fix regression after: #1980 Resolves: https://issues.redhat.com/browse/MTA-1390 Initial filter values work best if the table is not persisting state between reloads (default strategy, component state). If the table uses session or local storage then any existing filter overwrites the default value. From the end user perspective the functionality works only on the first load with a clean browser (no previous state). Switching to URL filter persistence provides the same functionality and ensures we have only one source of filters. Reference-Url: #1698 Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Resolves https://issues.redhat.com/browse/MTA-2008
&&
#1498