👻 force npm9 during image build (#1781) #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![konveyor-ci-bot[bot]](https://avatars.githubusercontent.com/in/819470?s=60&v=4){kind=small}
Ever since the build container we use [1][2] updated to use `npm@10`, the image builder github action has encountered a number of problems. The first was solved with #1746. The second more random problem has been with network connections erroring out when installing dependencies. To work around the network and nofiles errors: 1. enforce the use of `npm@9` 2. pin the Dockerfile base images to specific version tags; builder at `:1-88`, and runtime at `:1-93` Additional solutions: - Add the force to `npm@9` directly in the Dockerfile for use in all circumstances - Find a way to use something like verdaccio to proxy/mirror the npmjs repo during the build so npmjs fetches can be pooled across the parallel image builds [1] registry.access.redhat.com/ubi9/nodejs-18:latest [2] https://catalog.redhat.com/software/containers/ubi9/nodejs-18/62e8e7ed22d1d3c2dfe2ca01 --------- Signed-off-by: Scott J Dickerson <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
sjd78
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever since the build container we use [1][2] updated to use
npm@10,the image builder github action has encountered a number of problems.
The first was solved with #1746. The second more random problem has been
with network connections erroring out when installing dependencies.
To work around the network and nofiles errors:
npm@9builder at
:1-88, and runtime at:1-93Additional solutions:
npm@9directly in the Dockerfile for use in allcircumstances
repo during the build so npmjs fetches can be pooled across the parallel
image builds
[1] registry.access.redhat.com/ubi9/nodejs-18:latest
[2] https://catalog.redhat.com/software/containers/ubi9/nodejs-18/62e8e7ed22d1d3c2dfe2ca01
Signed-off-by: Scott J Dickerson [email protected]
Signed-off-by: Cherry Picker [email protected]