Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 [backport release-0.3] Test image build when build related files change (#1907) #1915

Merged
merged 1 commit into from
May 15, 2024

Commits on May 15, 2024

  1. 🌱 [backport release-0.3] Test image build when build related files ch…

    …ange (konveyor#1907)
    
    If the workflow is run from a PR, and the PR includes a change to the
    `Dockerfile` or `package-lock.json`, then run image builds for all of
    our target platforms.
    
    The images are built but not pushed to any repository.
    
    We want to be reasonably sure that any major build file changes will not
    cause the image-build-and-push on PR merge workflow to break. Doing the
    image build here should reveal most problems much earlier. For example,
    a npm version update in the build container could break github action
    `nofiles` or network access capabilities for the npm install.
    
    See konveyor#1742, konveyor#1746, and konveyor#1781 for some other examples of when this check
    could have caught issues before a PR merge.
    
    Supports: konveyor#1883
    Backport-of: konveyor#1907
    
    Note: build architectures updated to match the settings on the
          backport target branch
    
    Signed-off-by: Scott J Dickerson <[email protected]>
    sjd78 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    441d0b9 View commit details
    Browse the repository at this point in the history