👻 Align TaskStateIcon Icon status fields with IconedStatus #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rszwajko
approved these changes
Jul 1, 2024
Signed-off-by: Scott J Dickerson <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1989 +/- ##
==========================================
+ Coverage 39.20% 42.23% +3.03%
==========================================
Files 146 170 +24
Lines 4857 5443 +586
Branches 1164 1373 +209
==========================================
+ Hits 1904 2299 +395
- Misses 2939 3027 +88
- Partials 14 117 +103
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dymurray
pushed a commit
that referenced
this pull request
Jul 2, 2024
…1985) ## Summary On the application table's name column, add a status icon. The icon summarizes the status of the various kinds of tasks attached to an application (a single application has 0 or more tasks while a task acts on a single application). The icon will be driven off looking at the most recent task (by `createTime`) per `kind` for an application: - If there are no tasks, show the application in No Tasks state - Else if any are "running", show the application in Running - Else if any are "queued", show the application in Queued state - Else if any are "failed", show the application as Failed - Else if any are "canceled", show the application as Canceled - Else if any are "succeeded", show the application as Success A popover on hover will render on the application name column to display summary information about the application's tasks. The popover will have a table that shows the most recent tasks for each kind of task associated to the application. - Task id - Task status icon with the task kind - How long ago the task was started/created (exact time in a tooltip) Based on refactoring PR #1988 and PR #1989 Closes: #1934 Fixes: #1772 ## Change Details - Created `useDecoratedApplications()` hook to run all calculations and cross-referencing necessary to render most of the table. - Created `ColumnApplicationName` to handle the application name column with the status icon and popover. - Refactored `useFetchTasks()` hook to only do a simple sort. The filtering based on kind is no longer necessary. - The base `ApplicationsTable` received some basic refactoring to utilize the content of `DecoratedApplication` ## Screen Shots Base view with various application task statuses:  Popover details of an application with canceled tasks:  Popover details of an application with successful tasks:  Popover details of an application with failed tasks:  --------- Signed-off-by: Scott J Dickerson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align
TaskStateIconIcon status fields withIconedStatus.This amounts to setting some icons blue instead of black consistently across tables and the drawer.
Related to #1985