🐛 Fix packaging of fonts #2020
Merged
🐛 Fix packaging of fonts #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2020 +/- ##
==========================================
+ Coverage 39.20% 42.07% +2.87%
==========================================
Files 146 171 +25
Lines 4857 5511 +654
Branches 1164 1359 +195
==========================================
+ Hits 1904 2319 +415
- Misses 2939 3076 +137
- Partials 14 116 +102
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Update `webpack.common.ts` to the current patternfly-react-seed[^1] packaging configs for fonts. This allows the correct fonts to be used in the app - `RedHatText` over `helvetica`. This also resolves any browser console reported errors of the form: - `Failed to decode downloaded font: <url>` - `OTS parsing error: invalid sfntVersion: 1702391919` [^1]: https://github.com/patternfly/patternfly-react-seed Signed-off-by: Scott J Dickerson <[email protected]>
sjd78
force-pushed
the
fix_font_packaging
branch
from
3f3073d
to
66393a9
Compare
ibolton336
approved these changes
Jul 23, 2024
This was referenced Jul 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
webpack.common.tsto the current patternfly-react-seed1 packaging configs for fonts. This allows the correct fonts to be used in the app -RedHatTextoverhelvetica.This also resolves any browser console reported errors of the form:
Failed to decode downloaded font: <url>OTS parsing error: invalid sfntVersion: 1702391919Update
cleanscript for client package to include jest coverage reports.Resolves: #2021
Footnotes
https://github.com/patternfly/patternfly-react-seed ↩