Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix target card behavior and rendering #2025

Merged
merged 2 commits into from
Jul 24, 2024
Merged

🐛 Fix target card behavior and rendering #2025

merged 2 commits into from
Jul 24, 2024

Commits on Jul 24, 2024

  1. 🐛 Fix target card behavior and rendering 

    Resolves: konveyor#2022
Resolves: konveyor#2010
Resolves: konveyor#1981
Resolves: https://issues.redhat.com/browse/MTA-3094

Target card behavior and rendering on the target selection
step of the analysis wizard and on the custom migrations
target page have been updated:
  - All of the card contents render inside the card itself
    (konveyor#1981 / MTA-3094)
  - When changing the specific label selection for a target,
    the card selection will not changes (konveyor#2010)
  - The target label select now sorts the labels in numeric
    natural sort descending order.  `OpenJDK 21` will be
    initially selected and appear above `OpenJDK 17` in the
    select list. (konveyor#2022)
  - Layouts used on the card have been refactored to use base
    layouts instead of the `EmptyState` component
  - The target label select box has been updated to the
    current `SimpleSelectBasic` component for current PF5
    alignment
  - When card selection is enabled (on the target selection
    step of the analysis wizard), the selection checkbox is
    always displayed and the normal `Card` hover styles have
    been disabled.

Some refactoring on the `SetTargets` component used by the
analysis wizard have been made to simplify rendering code.

Signed-off-by: Scott J Dickerson <[email protected]>
    @sjd78
    sjd78 committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    ad33e89 View commit details
    Browse the repository at this point in the history

  2. Fix TargetCard selection event handling 

    Signed-off-by: Scott J Dickerson <[email protected]>
    @sjd78
    sjd78 committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    01c3c33 View commit details
    Browse the repository at this point in the history