Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Refactor dist npm script #2061

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

🌱 Refactor dist npm script #2061

wants to merge 2 commits into from

Conversation

sjd78
Copy link
Member

@sjd78 sjd78 commented Aug 22, 2024

Change the copy package used to generate the dist/ folder after building to use copy-files-from-to.

The package change allows us to have a configuration file with multiple includes and excludes to make sure we copy only exactly what is needed when the dist/ folder is built. The contents of the dist/ folder is what is copied into the runtime container. It should be as light as possible.

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.15%. Comparing base (b654645) to head (66190cd).
Report is 225 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2061      +/-   ##
==========================================
+ Coverage   39.20%   42.15%   +2.95%     
==========================================
  Files         146      174      +28     
  Lines        4857     5577     +720     
  Branches     1164     1325     +161     
==========================================
+ Hits         1904     2351     +447     
- Misses       2939     3210     +271     
- Partials       14       16       +2     
Flag Coverage Δ
client 42.15% <ø> (+2.95%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Change the copy package used to generate the `dist/`
folder after building to use `copy-files-from-to`.

The package change allows us to have a configuration
file with multiple includes and excludes to make sure
we copy only exactly what is needed when the `dist/`
folder is built.  The contents of the `dist/` folder
is what is copied into the runtime container.  It
should be as light as possible.

Signed-off-by: Scott J Dickerson <[email protected]>
@sjd78 sjd78 marked this pull request as draft September 9, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant