Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Extend filtering in the Set Target step #2092

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

rszwajko
Copy link
Collaborator

@rszwajko rszwajko commented Sep 13, 2024

Added filters:

  1. by name (freetext search)
  2. by custom target (yes/no select)
  3. by labels (multiselect)

Resolves: https://issues.redhat.com/browse/MTA-3702

@rszwajko
Copy link
Collaborator Author

Screenshot from 2024-09-13 18-25-58
Screenshot from 2024-09-13 18-26-49
Screenshot from 2024-09-13 18-26-43

@rszwajko rszwajko changed the title Extend filtering in the Set Target step ✨ Extend filtering in the Set Target step Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 23.07692% with 10 lines in your changes missing coverage. Please review.

Project coverage is 41.97%. Comparing base (b654645) to head (783d6a7).
Report is 238 commits behind head on main.

Files with missing lines Patch % Lines
...pages/applications/analysis-wizard/set-targets.tsx 18.18% 9 Missing ⚠️
client/src/app/utils/rules-utils.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2092      +/-   ##
==========================================
+ Coverage   39.20%   41.97%   +2.77%     
==========================================
  Files         146      175      +29     
  Lines        4857     5629     +772     
  Branches     1164     1341     +177     
==========================================
+ Hits         1904     2363     +459     
- Misses       2939     3250     +311     
- Partials       14       16       +2     
Flag Coverage Δ
client 41.97% <23.07%> (+2.77%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Added filters:
1. by name (freetext search)
2. by custom target (yes/no select)
3. by labels (multiselect)

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
@rszwajko rszwajko merged commit 9bd0b3b into konveyor:main Oct 4, 2024
12 checks passed
sarinailinger pushed a commit to sarinailinger/tackle2-ui that referenced this pull request Oct 30, 2024
Added filters:
1. by name (freetext search)
2. by custom target (yes/no select)
3. by labels (multiselect)

Resolves: https://issues.redhat.com/browse/MTA-3702

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants