✨ change button style #2096
Closed
✨ change button style #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DvoraShechter1
requested review from
ibolton336,
sjd78 and
rszwajko
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2096 +/- ##
==========================================
+ Coverage 39.20% 42.01% +2.81%
==========================================
Files 146 175 +29
Lines 4857 5617 +760
Branches 1164 1406 +242
==========================================
+ Hits 1904 2360 +456
- Misses 2939 3136 +197
- Partials 14 121 +107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
NpmStart2
approved these changes
Sep 16, 2024
NpmStart2
approved these changes
Sep 16, 2024
Related: konveyor/tackle2-hub#750 Signed-off-by: Jeff Ortel <[email protected]>
When a PR only contains changes to root level markdown, or anything under `docs/` or `hack/`, there is no need to run the CI github actions. To satisfy branch protection rules that may exist that require the "unit-test" job to run, the `ci-repo.yml` action looks up details about a PR and will skip the unit test if it detects that the only changes made in the PR are docs or hacks. The ignores do not apply to pushes to main, pushes to release, or workflow calls. Signed-off-by: Scott J Dickerson <[email protected]>
To help out people building images in a fork, use github action variables to be able to configure the target registry and image names. Now on a fork, the destination of an image build can be set by using action variables[^1]: - IMAGE_BUILD_REGISTRY (default: "quay.io/konveyor") - IMAGE_BUILD_IMAGE_NAME (default: "tackle2-ui") and action secrets[^2]: - QUAY_PUBLISH_ROBOT - QUAY_PUBLISH_TOKEN [^1]: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#creating-configuration-variables-for-a-repository [^2]: https://docs.github.com/en/actions/security-for-github-actions/security-guides/using-secrets-in-github-actions#creating-secret Signed-off-by: Scott J Dickerson <[email protected]>
Updated the database after starting to see a few DB out-of-date warnings. Signed-off-by: Scott J Dickerson <[email protected]>
…2093) Resolves: konveyor#2094 Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Fixes: 1. initial delay in first fetch - root cause was delayed initialization of sentinel reference 2. extra page fetch request - algorithm based on items count was not sufficient Reference-Url: konveyor#2049 Signed-off-by: Radoslaw Szwajkowski <[email protected]> Co-authored-by: Scott Dickerson <[email protected]> Signed-off-by: DvoraShechter1 <[email protected]>
Changes: 1. add persistence provider to feature level persistence (IFeaturePersistenceArgs) but not to table layer persistence (ITablePersistenceArgs). This simplifies the provider code (feature-specific providers). 2. remove meta-persistence target "default" - no target has the same effect. 3. when in persistence provider mode use default values when the deserialized value is nulish. This solves the problem of initialFilterValues being overwritten in target cards scenario (the hook is called more then once and useState() based logic fails to detect initial load). Using the newly added feature, store the filters selected in the Target step (Analysis wizard) inside react-hook form in the same way as other values. Resolves: https://issues.redhat.com/browse/MTA-3438 Signed-off-by: Radoslaw Szwajkowski <[email protected]> Co-authored-by: Scott Dickerson <[email protected]> Signed-off-by: DvoraShechter1 <[email protected]>
Signed-off-by: DvoraShechter1 <[email protected]>
DvoraShechter1
force-pushed
the
S&DjobFunctions
branch
2 times, most recently
from
683127d
to
e486984
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add ActionsColumn to Job Functions table:
change the actions columun in the Job Functions table -
to use patternnfly 5 controls, instead of patternnfly 4 controls like in the Stakeholder table