-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Adding a tooltip when the button is unavailable #2126
base: main
Are you sure you want to change the base?
Conversation
…age explaining the unavailability Signed-off-by: aviya-gidan <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2126 +/- ##
==========================================
+ Coverage 39.20% 41.94% +2.74%
==========================================
Files 146 175 +29
Lines 4857 5636 +779
Branches 1164 1400 +236
==========================================
+ Hits 1904 2364 +460
- Misses 2939 3256 +317
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Please attach some screenshots presenting the functionality. See also my comments below.
Signed-off-by: aviya-gidan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the problemI changed the string problem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
If you are using Fedora (which I recommend) with Gnome (the default) then you have excellent screenshot/screencast support via keyboard shortcuts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me. Is this PR fixing the issue you have listed in the description, they don't seem to quite match?
This is part of issue #1937: |
…age explaining the unavailability
Adding a tooltip when the button is unavailable and displaying a message
explaining the unavailability
issue:#1937