Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Adding a tooltip when the button is unavailable #2126

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

aviya-gidan
Copy link

…age explaining the unavailability

Adding a tooltip when the button is unavailable and displaying a message
explaining the unavailability
issue:#1937

…age explaining the unavailability

Signed-off-by: aviya-gidan <[email protected]>
@aviya-gidan aviya-gidan changed the title Adding a tooltip when the button is unavailable and displaying a mess… Non-breaking feature: (:sparkles:) Adding a tooltip when the button is unavailable Oct 27, 2024
@aviya-gidan aviya-gidan changed the title Non-breaking feature: (:sparkles:) Adding a tooltip when the button is unavailable Non-breaking feature: Adding a tooltip when the button is unavailable Oct 27, 2024
@aviya-gidan aviya-gidan changed the title Non-breaking feature: Adding a tooltip when the button is unavailable ✨ Adding a tooltip when the button is unavailable Oct 27, 2024
@aviya-gidan aviya-gidan changed the title ✨ Adding a tooltip when the button is unavailable ✨ Adding a tooltip when the button is unavailable Oct 27, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 41.94%. Comparing base (b654645) to head (077c09f).
Report is 244 commits behind head on main.

Files with missing lines Patch % Lines
client/src/app/pages/tasks/useTaskActions.tsx 0.00% 6 Missing ⚠️
.../app/components/task-manager/TaskManagerDrawer.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2126      +/-   ##
==========================================
+ Coverage   39.20%   41.94%   +2.74%     
==========================================
  Files         146      175      +29     
  Lines        4857     5636     +779     
  Branches     1164     1400     +236     
==========================================
+ Hits         1904     2364     +460     
- Misses       2939     3256     +317     
- Partials       14       16       +2     
Flag Coverage Δ
client 41.94% <0.00%> (+2.74%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rszwajko rszwajko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please attach some screenshots presenting the functionality. See also my comments below.

client/src/app/pages/tasks/useTaskActions.tsx Outdated Show resolved Hide resolved
Signed-off-by: aviya-gidan <[email protected]>
Copy link
Author

@aviya-gidan aviya-gidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the problemI changed the string problem

@aviya-gidan
Copy link
Author

aviya-gidan commented Oct 30, 2024

Screenshot from 2024-11-02 22-46-58

Copy link
Collaborator

@rszwajko rszwajko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rszwajko
Copy link
Collaborator

@aviya-gidan

The screenshot is not clear because it is impossible to take a screenshot when the mouse is on the button

If you are using Fedora (which I recommend) with Gnome (the default) then you have excellent screenshot/screencast support via keyboard shortcuts.

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. Is this PR fixing the issue you have listed in the description, they don't seem to quite match?

@aviya-gidan
Copy link
Author

aviya-gidan commented Nov 5, 2024

Code looks good to me. Is this PR fixing the issue you have listed in the description, they don't seem to quite match?

This is part of issue #1937:
"Action on the tasks may be allowed based on task kind and if the current user is the creator of the task. Put the set of action on a kebab menu for a task, with actions not currently permitted to be disabled with a tooltip explaining why."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants