Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor geoservices plugin #625

Merged
merged 3 commits into from
Jul 5, 2023
Merged

Refactor geoservices plugin #625

merged 3 commits into from
Jul 5, 2023

Conversation

rgwozdz
Copy link
Member

@rgwozdz rgwozdz commented Jun 30, 2023

This PR is a refactor of the code comprising the geoservices output plugin:

  • move to class syntax
  • use await
  • move handling of errors in pull-data or auth methods out of FeatureServer and into geoservice handlers (FeatureServer should only handle errors generated in it part of the request/response sequence, not prior to)
  • add unit tests
  • add e2e tests

@rgwozdz rgwozdz self-assigned this Jun 30, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jun 30, 2023

🦋 Changeset detected

Latest commit: 34d8317

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@koopjs/featureserver Major
@koopjs/output-geoservices Major
@koopjs/koop-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rgwozdz rgwozdz added refactor internal Changes only affect the internal API labels Jun 30, 2023
@rgwozdz rgwozdz requested a review from sansth1010 July 5, 2023 15:15
sansth1010
sansth1010 approved these changes Jul 5, 2023
View reviewed changes
Copy link

@sansth1010 sansth1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Great work on the refactor!

@rgwozdz rgwozdz merged commit cebf208 into master Jul 5, 2023
5 checks passed
@rgwozdz rgwozdz deleted the rf/geoservices branch July 5, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sansth1010 sansth1010 sansth1010 approved these changes

Assignees

@rgwozdz rgwozdz

Labels
internal Changes only affect the internal API refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgwozdz @sansth1010