Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: remove deepCopy of reservationInfo #2169

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ZiMengSheng
Copy link
Contributor

@ZiMengSheng ZiMengSheng commented Aug 15, 2024

Ⅰ. Describe what this PR does

就是为了去掉这个,但是不想加锁,所以这样操作下
image

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from zimengsheng after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 77.39130% with 26 lines in your changes missing coverage. Please review.

Project coverage is 67.87%. Comparing base (d376bf5) to head (473a63c).
Report is 58 commits behind head on main.

Files with missing lines Patch % Lines
pkg/scheduler/plugins/reservation/cache.go 80.35% 9 Missing and 2 partials ⚠️
pkg/scheduler/plugins/reservation/snapshot.go 76.74% 9 Missing and 1 partial ⚠️
pkg/scheduler/frameworkext/reservation_info.go 54.54% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2169      +/-   ##
==========================================
- Coverage   67.87%   67.87%   -0.01%     
==========================================
  Files         443      444       +1     
  Lines       41921    42024     +103     
==========================================
+ Hits        28454    28523      +69     
- Misses      11013    11040      +27     
- Partials     2454     2461       +7     
Flag Coverage Δ
unittests 67.87% <77.39%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1,94 @@
package reservation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a license header

Copy link

stale bot commented Nov 18, 2024

This issue has been automatically marked as stale because it has not had recent activity.
This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the issue is closed
    You can:
  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close
    Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants