koordlet: support change pod CPUQOS by annotations #2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2206 +/- ##
=======================================
Coverage 66.01% 66.02%
=======================================
Files 453 453
Lines 53374 53387 +13
=======================================
+ Hits 35236 35247 +11
- Misses 15597 15601 +4
+ Partials 2541 2539 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
seems we need some UT for this |
zwzhang0107
reviewed
Sep 25, 2024
j4ckstraw
force-pushed
the
feat/tune-cpuqos-by-annotation
branch
2 times, most recently
from
45c7bd2
to
2c207ae
Compare
j4ckstraw
force-pushed
the
feat/tune-cpuqos-by-annotation
branch
from
2c207ae
to
6c0835e
Compare
j4ckstraw
force-pushed
the
feat/tune-cpuqos-by-annotation
branch
3 times, most recently
from
6a3c355
to
91c0b68
Compare
saintube
changed the title
j4ckstraw
force-pushed
the
feat/tune-cpuqos-by-annotation
branch
from
91c0b68
to
afac8d7
Compare
Signed-off-by: j4ckstraw <[email protected]>
j4ckstraw
force-pushed
the
feat/tune-cpuqos-by-annotation
branch
from
afac8d7
to
1ddd85d
Compare
|
It's verified finnaly. PTAL @zwzhang0107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test