-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: export host application cpu and memory usage for prometheus #2259
base: main
Are you sure you want to change the base?
Conversation
31d2a7b
to
515ffd0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2259 +/- ##
==========================================
+ Coverage 66.01% 66.03% +0.02%
==========================================
Files 453 454 +1
Lines 53378 53393 +15
==========================================
+ Hits 35237 35258 +21
+ Misses 15603 15595 -8
- Partials 2538 2540 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: yangfeiyu20102011 <[email protected]>
515ffd0
to
14462c3
Compare
PTAL @saintube |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
PTAL /cc @zwzhang0107
可以补充host-application-memory-uasage-with-page-cache #2273 |
We can collect page cache in another PR. |
Ⅰ. Describe what this PR does
To better monitor the resource usage of the host application, Prometheus metrics have been added.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test