Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: export host application cpu and memory usage for prometheus #2259

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yangfeiyu20102011
Copy link
Contributor

Ⅰ. Describe what this PR does

To better monitor the resource usage of the host application, Prometheus metrics have been added.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@yangfeiyu20102011 yangfeiyu20102011 changed the title koordlet: export host application cpu and memory usage for prometheus 【WIP】koordlet: export host application cpu and memory usage for prometheus Nov 11, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 68.18182% with 7 lines in your changes missing coverage. Please review.

Project coverage is 66.03%. Comparing base (81dfad9) to head (14462c3).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/koordlet/metrics/host_application.go 60.00% 4 Missing and 2 partials ⚠️
...r/collectors/hostapplication/host_app_collector.go 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2259      +/-   ##
==========================================
+ Coverage   66.01%   66.03%   +0.02%     
==========================================
  Files         453      454       +1     
  Lines       53378    53393      +15     
==========================================
+ Hits        35237    35258      +21     
+ Misses      15603    15595       -8     
- Partials     2538     2540       +2     
Flag Coverage Δ
unittests 66.03% <68.18%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yangfeiyu20102011 yangfeiyu20102011 changed the title 【WIP】koordlet: export host application cpu and memory usage for prometheus koordlet: export host application cpu and memory usage for prometheus Nov 12, 2024
@yangfeiyu20102011
Copy link
Contributor Author

PTAL @saintube
Thanks.

@saintube saintube requested review from saintube and zwzhang0107 and removed request for saintube November 13, 2024 09:11
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
PTAL /cc @zwzhang0107

@saintube saintube added the lgtm label Nov 13, 2024
@j4ckstraw
Copy link
Contributor

可以补充host-application-memory-uasage-with-page-cache #2273

@yangfeiyu20102011
Copy link
Contributor Author

可以补充host-application-memory-uasage-with-page-cache #2273

We can collect page cache in another PR.
This PR is solely focused on exporting metrics for Prometheus.
cc @j4ckstraw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants