Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement kornia3d::pose for homography and affine #194

Merged
merged 5 commits into from
Dec 25, 2024
Merged

Conversation

edgarriba
Copy link
Member

@edgarriba edgarriba commented Dec 25, 2024

Part of #189

This pull request introduces several significant improvements and new features to the kornia-3d and kornia-icp crates. The most important changes include adding new dependencies, enhancing existing functions, and introducing new modules and tests.

Dependency Updates:

  • Added faer = "0.20.1" to Cargo.toml and updated faer to use the workspace version in crates/kornia-3d/Cargo.toml and crates/kornia-icp/Cargo.toml. [1] [2] [3]

Enhancements to Existing Functions:

  • Modified transform_points3d to return a Result and added error handling for mismatched lengths of input arrays.
  • Renamed several functions in crates/kornia-3d/src/linalg.rs for clarity and added new mathematical functions such as frobenius_norm33, mat33_div_scalar_inplace, det_mat33, cross_vec3, and normalize_mat33_inplace. [1] [2] [3] [4]

New Modules and Functions:

  • Added a new pose module in crates/kornia-3d/src/lib.rs with submodules affine and homography. These submodules include functions for computing affine and homography transformations from point correspondences. [1] [2] [3] [4]

Test Enhancements:

  • Added comprehensive tests for the new and updated functions in crates/kornia-3d/src/linalg.rs, crates/kornia-3d/src/pose/affine.rs, and crates/kornia-3d/src/pose/homography.rs. These tests ensure the correctness of transformations and mathematical operations. [1] [2] [3]

Error Handling Improvements:

  • Updated icp_vanilla function in crates/kornia-icp/src/icp_vanilla.rs to handle errors by propagating them using the ? operator. [1] [2] [3]

@edgarriba edgarriba merged commit 9710e4d into main Dec 25, 2024
9 checks passed
@edgarriba edgarriba deleted the pose-homography branch January 2, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant