Implement kornia3d::pose
for homography and affine
#194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #189
This pull request introduces several significant improvements and new features to the
kornia-3d
andkornia-icp
crates. The most important changes include adding new dependencies, enhancing existing functions, and introducing new modules and tests.Dependency Updates:
faer = "0.20.1"
toCargo.toml
and updatedfaer
to use the workspace version incrates/kornia-3d/Cargo.toml
andcrates/kornia-icp/Cargo.toml
. [1] [2] [3]Enhancements to Existing Functions:
transform_points3d
to return aResult
and added error handling for mismatched lengths of input arrays.crates/kornia-3d/src/linalg.rs
for clarity and added new mathematical functions such asfrobenius_norm33
,mat33_div_scalar_inplace
,det_mat33
,cross_vec3
, andnormalize_mat33_inplace
. [1] [2] [3] [4]New Modules and Functions:
pose
module incrates/kornia-3d/src/lib.rs
with submodulesaffine
andhomography
. These submodules include functions for computing affine and homography transformations from point correspondences. [1] [2] [3] [4]Test Enhancements:
crates/kornia-3d/src/linalg.rs
,crates/kornia-3d/src/pose/affine.rs
, andcrates/kornia-3d/src/pose/homography.rs
. These tests ensure the correctness of transformations and mathematical operations. [1] [2] [3]Error Handling Improvements:
icp_vanilla
function incrates/kornia-icp/src/icp_vanilla.rs
to handle errors by propagating them using the?
operator. [1] [2] [3]