Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update dependencies #22

wants to merge 1 commit into from

Conversation

Alyetama
Copy link

The current version of feedparser and dateparser are no longer compatible with the source code. The latest versions of both packages work fine. I updated pyproject.toml (and subsequently poetry.lock using the poetry lock command) to reflect that. I have also added a new entry in .gitignore to ignore macOS-generated system files (I use macOS), and added a new line at the end of __init__.py (just a habit!).

Copy link

@Pyth3rEx Pyth3rEx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition ;)

@Alyetama
Copy link
Author

For those who are unable to use the package due to the outdated dependencies, you can fix the issue by running:

pip install -U --no-deps "dateparser>=1.0.0"
pip install -U --no-deps "feedparser>=6.0.8"

@Alyetama Alyetama mentioned this pull request Oct 5, 2021
@NicolasCaousGV
Copy link

To anyone who wants to use this lib but can't install, you can force the dependencies to be a specific version this way:

python -m pip install "beautifulsoup4==4.9.1"
python -m pip install "dateparser==0.7.6"
python -m pip install "requests==2.24.0"
python -m pip install "feedparser==6.0.8"
python -m pip install --no-deps pygooglenews

This should work. (If it doesn't, check if the versions have changed in pyproject.toml for some reason)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants