Fix error on delete label #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodcloutier
force-pushed
the
fix-error-on-delete-label
branch
3 times, most recently
from
954bbff
to
6abedc0
Compare
mrueg
reviewed
Aug 30, 2024
rodcloutier
force-pushed
the
fix-error-on-delete-label
branch
3 times, most recently
from
9903184
to
4e950fa
Compare
Allow status code 204 to be valid and not error on label delete
rodcloutier
force-pushed
the
fix-error-on-delete-label
branch
from
4e950fa
to
43125a9
Compare
|
thanks, looks good. Will merge it this Friday after #487 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #495
PR to alllow http status 204 as valid when deleting labels.
Note: This depends on PR kovetskiy/gopencils#3 and go.mod/go.sum must be updated once merged