Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make app version configurable #68

Merged
merged 11 commits into from
Jul 28, 2024

Conversation

krazkidd
Copy link
Owner

This makes the app version configurable from any build path. It will default to "0.0.0" to signify a local dev build. The GitHub workflow is automated to pass the git tag name to the build. Tagged versions must now no longer include the "v" prefix (as they must conform to CMake's project comamnd spec.

@krazkidd krazkidd linked an issue Jul 28, 2024 that may be closed by this pull request
1 task
@krazkidd krazkidd self-assigned this Jul 28, 2024
Copy link

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format reports: 1 file(s) not formatted
  • src/ui/MainFrame.cpp
clang-tidy reports: 1 concern(s)
  • src/ui/MainFrame.cpp:3:10: error: [clang-diagnostic-error]

    'wx/string.h' file not found

    #include <wx/string.h>
             ^

Have any feedback or feature suggestions? Share it here.

@krazkidd krazkidd merged commit 7d812de into main Jul 28, 2024
1 check failed
@krazkidd krazkidd deleted the 67-pass-git-version-tag-eg-v100-to-cmake branch July 28, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass git version tag (e.g. "v1.0.0") to CMake
1 participant