Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ffmpeg): Update version to 4.3.1 #48

Closed
wants to merge 3 commits into from

Conversation

eliotik
Copy link

@eliotik eliotik commented Nov 11, 2020

Updated ffmpeg binaries for:

  • darwin, linux platforms
  • windows platform skipped

Updated ffmpeg binaries for:
- darwin, linux platforms
- windows platform skipped
@eliotik
Copy link
Author

eliotik commented Nov 11, 2020

Hi @kribblo , can you please merge it and then do platform/* npm run upload?
I cannot upload new version of ffmpeg binaries to npm registry since I'm not owner of these optional repositories.

@whyboris
Copy link

Looks like there's a fork that is more up to date 🤔
https://github.com/devdanim/dnm-node-ffmpeg-installer

@whyboris
Copy link

There's also this: https://github.com/SavageCore/node-ffprobe-installer 🤔 unsure if it's a good alternative

@deevus
Copy link
Collaborator

deevus commented Mar 12, 2021

Yo what's the hold on this @kribblo

@kribblo
Copy link
Owner

kribblo commented Mar 12, 2021

Hey sorry, because of reasons maybe more people should maintain or take over this, started a discussion about it and will be happy to invite help: #52

@deevus
Copy link
Collaborator

deevus commented Mar 14, 2021

@eliotik Are you able to update these to 4.3.2 and squash?

@deevus
Copy link
Collaborator

deevus commented Mar 14, 2021

For Windows builds, can we use https://github.com/GyanD/codexffmpeg

@deevus
Copy link
Collaborator

deevus commented Mar 14, 2021

@deevus
Copy link
Collaborator

deevus commented Mar 14, 2021

@whyboris @eliotik Any thoughts on #53?

@goatandsheep
Copy link

fixes #36

@eliotik eliotik closed this Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants