-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
These changes make it so Baker working with django 3.0 #26
Open
opencoca
wants to merge
18
commits into
krisfields:master
Choose a base branch
from
opencoca:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from jango.db.models.fields import FieldDoesNotExist does not work with Django 3.0 instead import from django.core.exceptions
Django 3 doesn't support 'django.utils.six' instead direct import from six
opencoca
added a commit
to opencoca/lt2d_school_admin
that referenced
this pull request
Dec 4, 2020
There is a small typo in README.rst. Should read `override` rather than `ovverride`.
docs: fix simple typo, ovverride -> override
mark_safe is added to create links between tables.
…ns and six (#3) * Update FieldDoesNotExist in admin.py FieldDoesNotExist is now located under django.core.exceptions. Therefor the from import had to be updated. * Update six in baker.py six has changed in the meantime therefore the from import had to be updated. Co-authored-by: Ramin-Shemirani <[email protected]>
I really don't have the time to look through these pull requests anymore. It seems like you might. |
@krisfields Yes I would be happy to. I use baker quite a bit in my projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.