Skip to content
This repository has been archived by the owner on Nov 13, 2023. It is now read-only.

Commit

Permalink
critical bug fix to corners (#126)
Browse files Browse the repository at this point in the history
* critical bug fix to corners

* increasing assert tolerance
  • Loading branch information
Keith Roberts authored Nov 4, 2020
1 parent 07c9aab commit a3af79a
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 3 deletions.
12 changes: 9 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -483,19 +483,25 @@ Changelog
=========

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project (tries to) adhere to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Unreleased
- None

## [3.1.2] - 2020-11-04
### Improved
- Faster calculation of boundary vertices.
- Faster calculation of boundary vertices.
- More robust sliver removal in 3D.
### Fixed
- Corners are only constrained for constant resolution meshes

## [3.1.0] - 2020-10-28
### Added
- New geometric primitives--torus, wedge/prism, and cylinder.
- Updated images on README.
### Fixed
- Only constrain corners near 0-level set.
- Bug fix to 3D binary velocity reading.
- Bug fix to 3D binary velocity reading.

## [3.0.6] - 2020-10-21
### Fixed
Expand Down
7 changes: 7 additions & 0 deletions SeismicMesh/generation/mesh_generator.py
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,10 @@ def print_msg2(msg):
# unpack domain
fd, bbox0, corners = _unpack_domain(domain, gen_opts)

# discard corners for now
if not np.isscalar(edge_length):
corners = None

fh, bbox1, hmin = _unpack_sizing(edge_length)

# take maxmin of boxes for the case of domain padding
Expand Down Expand Up @@ -479,6 +483,9 @@ def print_msg2(msg):
"Iteration #%d, max movement is %f, there are %d vertices and %d cells"
% (count + 1, maxdp, len(p), len(t)),
)
assert (
maxdp < 50 * h0
), "max movement indicates there's a convergence problem"

count += 1

Expand Down

0 comments on commit a3af79a

Please sign in to comment.