Skip to content

Commit

Permalink
Make linting rules more consistent
Browse files Browse the repository at this point in the history
 * Put back babel-eslint for class-properties
 * Allow arrow functions without params

This makes the style more consistent with react-sdk.

NB. The line lengths are still inconsistent but it's not clear which
way to go on that yet.
  • Loading branch information
dbkr committed Feb 5, 2019
1 parent a6970d4 commit 17e2cd7
Show file tree
Hide file tree
Showing 3 changed files with 224 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module.exports = {
parser: "babel-eslint", // now needed for class properties
parserOptions: {
ecmaVersion: 2017,
sourceType: "module",
ecmaFeatures: {
}
Expand Down Expand Up @@ -72,5 +72,6 @@ module.exports = {
"named": "never",
"asyncArrow": "always",
}],
"arrow-parens": "off",
}
}
221 changes: 221 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@
},
"devDependencies": {
"babel-cli": "^6.18.0",
"babel-eslint": "^10.0.1",
"babel-plugin-transform-async-to-bluebird": "^1.1.1",
"babel-plugin-transform-runtime": "^6.23.0",
"babel-preset-es2015": "^6.18.0",
Expand Down

0 comments on commit 17e2cd7

Please sign in to comment.