Skip to content

Commit

Permalink
Merge pull request kubernetes#11312 from mm4tt/logexporter
Browse files Browse the repository at this point in the history
Log stdout/stderr of gcloud auth command.
  • Loading branch information
k8s-ci-robot authored Feb 19, 2019
2 parents 4d47e63 + f3561b4 commit b2d27d0
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 4 deletions.
2 changes: 1 addition & 1 deletion logexporter/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

PROJECT = k8s-testimages
IMG = gcr.io/$(PROJECT)/logexporter
TAG = v0.1.5
TAG = v0.1.6

.PHONY: build push

Expand Down
2 changes: 1 addition & 1 deletion logexporter/cluster/logexporter-daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ spec:
spec:
containers:
- name: logexporter-test
image: gcr.io/k8s-testimages/logexporter:v0.1.5
image: gcr.io/k8s-testimages/logexporter:v0.1.6
env:
- name: NODE_NAME
valueFrom:
Expand Down
2 changes: 1 addition & 1 deletion logexporter/cluster/logexporter-pod.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ metadata:
spec:
containers:
- name: logexporter-test
image: gcr.io/k8s-testimages/logexporter:v0.1.5
image: gcr.io/k8s-testimages/logexporter:v0.1.6
env:
- name: NODE_NAME
valueFrom:
Expand Down
9 changes: 8 additions & 1 deletion logexporter/cmd/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ limitations under the License.
package main

import (
"bytes"
"flag"
"fmt"
"io"
Expand Down Expand Up @@ -77,8 +78,14 @@ func checkConfigValidity() error {
if _, err := os.Stat(*gcloudAuthFilePath); err != nil {
return fmt.Errorf("Could not find the gcloud service account file: %v", err)
} else {
glog.Infof("Running gcloud auth activate-service-account --key-file=%s\n", *gcloudAuthFilePath)
cmd := exec.Command("gcloud", "auth", "activate-service-account", "--key-file="+*gcloudAuthFilePath)
if err := cmd.Run(); err != nil {
var stderr, stdout bytes.Buffer
cmd.Stderr, cmd.Stdout = &stderr, &stdout
err = cmd.Run()
glog.Infof("Stdout:\n%s\n", stdout.String())
glog.Infof("Stderr:\n%s\n", stderr.String())
if err != nil {
return fmt.Errorf("Failed to activate gcloud service account: %v", err)
}
}
Expand Down

0 comments on commit b2d27d0

Please sign in to comment.