Fix | Fixed WorkflowEventSubscriber extracting WorkflowJob on non WorkflowJob jobs #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simple-hacker
changed the title
|
Hey, it'll unfortunately be a few weeks before I'll get around to this as I'm currently on vacation. My first reaction is that I'm not a super big fan of adding this check to the |
simple-hacker
force-pushed
the
fix/WorkflowEventSubscriber
branch
2 times, most recently
from
b7e6f20 to
2f39f2c
Compare
Understood. It's working for me and our application at the moment so we're going to continue to use our fork, but will keep an eye out for this. Thanks for the package anyway, it's amazing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90
Fixes #65
Using @stevebauman suggestion, when subscribing to events in WorkflowSubscriber, if the incoming event is not a WorkflowJob job then we return early, and so it will not try to extract the WorkflowJob from the event using the Base64WorkflowSerializer.
I'm not sure what tests I can write sorry. I have tested this in both the minimal repository I made in the issue, and in my production app, and can confirm these are now working again, as well as the Venture test suite is passing again.
Happy to discuss how I can write the test here to confirm it's working properly.