Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Replace SecondaryButton with Text in DateTimeSelector #549

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Jan 19, 2025

TL;DR

Replaced SecondaryButton with Text component in DateTimeSelectorScreen's reset button

What changed?

  • Removed SecondaryButton usage in DateTimeSelectorScreen
  • Implemented reset functionality using a clickable Text component with proper styling and padding
  • Added TODO comments for future button component implementations (CtaButton, Button, SubtleButton)

How to test?

  1. Navigate to the DateTimeSelectorScreen
  2. Verify the "Reset" button appears in the TitleBar
  3. Click the reset button and confirm it:
    • Updates the date to current date
    • Updates time to current time
    • Sets journey time option to "LEAVE"
    • Triggers reset functionality

Why make this change?

To simplify the reset button implementation and lay groundwork for a more consistent button component system across the application. This change removes dependency on SecondaryButton while maintaining the same functionality with a more basic Text component.

@ksharma-xyz ksharma-xyz changed the title USe cta text button instead of secondary button for reset UI: Replace SecondaryButton with Text in DateTimeSelector Jan 19, 2025
@ksharma-xyz ksharma-xyz marked this pull request as ready for review January 19, 2025 00:26
@ksharma-xyz ksharma-xyz force-pushed the 01-18-add_reusable_title_bar_navigation_action_button branch from 0c88782 to d916a4c Compare January 19, 2025 01:53
Base automatically changed from 01-18-add_reusable_title_bar_navigation_action_button to main January 19, 2025 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant