Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Replace ThemeColor with KrailThemeStyle enum #568

Merged
merged 1 commit into from
Jan 25, 2025
Merged

UI: Replace ThemeColor with KrailThemeStyle enum #568

merged 1 commit into from
Jan 25, 2025

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Jan 25, 2025 •
edited
Loading

TL;DR

Removed unused ThemeColor data class and helper functions, keeping only the KrailThemeStyle enum and default value

@ksharma-xyz ksharma-xyz mentioned this pull request Jan 25, 2025
Merged
@ksharma-xyz Graphite App
Copy link
Owner Author

ksharma-xyz commented Jan 25, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ksharma-xyz ksharma-xyz mentioned this pull request Jan 25, 2025
Merged
@ksharma-xyz ksharma-xyz changed the title Remove comments UI: Remove unused ThemeColor code and comments Jan 25, 2025
@ksharma-xyz ksharma-xyz force-pushed the 01-25-remove_comments branch from 4705aec to 5c28133 Compare January 25, 2025 01:35
@ksharma-xyz ksharma-xyz changed the title UI: Remove unused ThemeColor code and comments UI: Replace ThemeColor with KrailThemeStyle enum Jan 25, 2025
@ksharma-xyz ksharma-xyz marked this pull request as ready for review January 25, 2025 01:35
@ksharma-xyz ksharma-xyz changed the base branch from 01-24-update_analytics_app_start_event to graphite-base/568 January 25, 2025 01:37
@ksharma-xyz ksharma-xyz force-pushed the 01-25-remove_comments branch from 5c28133 to c1033e8 Compare January 25, 2025 01:38
@ksharma-xyz ksharma-xyz changed the base branch from graphite-base/568 to main January 25, 2025 01:38
@ksharma-xyz ksharma-xyz force-pushed the 01-25-remove_comments branch from c1033e8 to 2be54b9 Compare January 25, 2025 01:38
@ksharma-xyz ksharma-xyz merged commit 46724e1 into main Jan 25, 2025
2 checks passed
@ksharma-xyz Graphite App
Copy link
Owner Author

Merge activity

  • Jan 24, 8:49 PM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz deleted the 01-25-remove_comments branch January 25, 2025 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ksharma-xyz