Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Remove Barbie theme and update pink color code #583

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Feb 2, 2025

TL;DR

Updated theme color values and removed Barbie theme option

What changed?

  • Renamed barbiePink to barbie_pink_theme and updated its color value from 0xFFDA1884 to 0xFFAA0999
  • Removed the BarbiePink enum option from KrailThemeStyle

How to test?

  1. Build and run the app
  2. Verify the new pink color (0xFFAA0999) is displayed correctly where used
  3. Confirm the Barbie theme option is no longer available in theme selection

Why make this change?

To maintain consistency in theme naming conventions and remove an unused theme option while updating the pink color to better match the application's color palette.

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ksharma-xyz ksharma-xyz changed the title Remove pink barbie theme UI: Remove Barbie theme and update pink color code Feb 2, 2025
@ksharma-xyz ksharma-xyz marked this pull request as ready for review February 2, 2025 02:42
Copy link
Owner Author

ksharma-xyz commented Feb 2, 2025

Merge activity

  • Feb 1, 9:42 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Feb 1, 9:55 PM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz merged commit dc135c5 into main Feb 2, 2025
4 checks passed
@ksharma-xyz ksharma-xyz deleted the 01-29-remove_pink_barbie_theme branch February 2, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant