UI: Remove transport theme colors from KrailColors #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksharma-xyz
changed the title
ksharma-xyz
force-pushed
the
02-06-remove_unnecessary_colors_from_color_tokens
branch
from
e9c9a8b to
88275c4
Compare
ksharma-xyz
force-pushed
the
02-06-remove_unnecessary_colors_from_color_tokens
branch
from
88275c4 to
ded2b8e
Compare
Merge activity
|
ksharma-xyz
deleted the
02-06-remove_unnecessary_colors_from_color_tokens
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Removed transport-specific theme colors from the KrailColors data class
What changed?
Removed color properties related to specific transport modes (bus, train, ferry, coach, metro, light rail) and their corresponding "on" colors from the KrailColors data class and its implementations in both light and dark themes.
How to test?
Why make this change?
Transport-specific theming is being handled elsewhere in the application, making these color definitions redundant in the base KrailColors class. This change simplifies the color system and reduces maintenance overhead by removing unused color properties.