project added #1
Conversation
There was a problem hiding this comment.
funkcyjne komponenty React'owe robimy bez tego React.FC, jako zwykłą funkcję
| backgroundSize: "contain", | ||
| backgroundPosition: "center top", | ||
| backgroundRepeat: "no-repeat", | ||
| height: "25vh", |
There was a problem hiding this comment.
raczej podawać wielkości w tailwindzie, a nie tak, bo wtedy prościej uzyskać responsywaność, zatem stylowanie przerobić na tailwind
|
|
||
|
|
||
| <div | ||
| className="absolute top-10 left-0 right-0 bg-no-repeat bg-contain bg-center opacity-20" |
|
|
||
| <div className="relative z-10 pt-[32vh] p-10 text-center"> | ||
| <h2 className="text-dark-text-primary text-4xl ">Nasze Projekty</h2> | ||
| <div className="w-[811px] h-1 bg-action-blue mx-auto mt-2"></div> |
There was a problem hiding this comment.
arbitralne wartości lepiej zastąpić czymś co będzie się skalowało, jak już muszą być konkretne liczby, to lepiej skorzystać z liczb wbudowanych w tailwind
| ]; | ||
|
|
||
|
|
||
| const Projects: React.FC = () => { |
There was a problem hiding this comment.
inaczej robimy komponenty reactowe
| <p className="text-dark-text-secondary">{description}</p> | ||
| </div> | ||
| <div> | ||
| <img src={image} alt="zosia" className="rounded-lg min-w-[210px] aspect-square object-cover" /> |
There was a problem hiding this comment.
pozbyć się losowych liczb
There was a problem hiding this comment.
wpasować się w podział projektu, widoczny w branchu feature-main-page
| @@ -0,0 +1,28 @@ | |||
| const ZosiaSection: React.FC = () => { | |||
| return ( | |||
| <div className="relative bg-dark-background-primary h-[60vh] text-white flex flex-col items-center"> | |||
There was a problem hiding this comment.
skorzystać z tailwindowych wartości, zrezygnować z absolute
| "build": "tsc -b && vite build", | ||
| "lint": "eslint .", | ||
| "build": "tsc && vite build", | ||
| "lint": "eslint . --ext ts,tsx --report-unused-disable-directives --max-warnings 0", |
There was a problem hiding this comment.
raczej nie chcemy configa zmieniać
| "typescript": "~5.6.2", | ||
| "typescript-eslint": "^8.18.2", | ||
| "vite": "^6.0.5" | ||
| "@types/react": "^18.2.48", |
There was a problem hiding this comment.
wziąć package.json z master albo z feature-main-page
No description provided.