Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parsing an Uri to OtpUri #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xZise
Copy link

@xZise xZise commented Nov 23, 2024

This adds support for extracting the different values from an Uri for an Otp. It only accepts valid input combinations/values and failes whenever it doesn't look like an correct uri.

@xZise
Copy link
Author

xZise commented Nov 23, 2024

I implemented it for the constructor but maybe it should be a static method like TryParse() or Parse. I was also thinking about whether to not fail as hard with issues (e.g. when providing a counter to when using TOTP) or to disable the exceptions via a parameter.

This might also implement #66.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant