Check if it's a target on every event so that we don't get lost #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use the
patterns:option and if themod_namedoes not match, we skip to push it to the@stackon:callevent. However, we are still accessing the@stackon other events even if the module actually does not match. This causes incorrect RBS generation. For example, with the current implementation, the return type ofTraceMethodTest::CallsOtherModule.calls_other_module_method(in the test added here) will be Integer while the actual type is String. It's because the return value ofM.new(0).a_tenwas accidentally used due to this issue.