Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comparison of Integer with nil failed in YARD/MeaninglessTag #23

Merged
merged 3 commits into from
Dec 9, 2023
Merged

Fix comparison of Integer with nil failed in YARD/MeaninglessTag #23

merged 3 commits into from
Dec 9, 2023

Conversation

sue445
Copy link
Contributor

@sue445 sue445 commented Dec 9, 2023

Since rubocop-yard v0.9.1, I have been getting the following error (v0.9.0 has no problem)

backtrace 
[[email protected]] [12-09 16:29:04] $ bundle exec rubocop -d -- lib/rubocop/cop/isucon/mysql2/n_plus_one_query.rb
For /Users/sue445/workspace/github.com/sue445/rubocop-isucon: configuration from /Users/sue445/workspace/github.com/sue445/rubocop-isucon/.rubocop.yml
configuration from /Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-performance-1.19.1/config/default.yml
configuration from /Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-performance-1.19.1/config/default.yml
Default configuration from /Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/config/default.yml
configuration from /Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-yard-0.9.1/config/default.yml
configuration from /Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-yard-0.9.1/config/default.yml
Use parallel by default.
Skipping parallel inspection: only a single file needs inspection
Inspecting 1 file
Scanning /Users/sue445/workspace/github.com/sue445/rubocop-isucon/lib/rubocop/cop/isucon/mysql2/n_plus_one_query.rb
An error occurred while YARD/MeaninglessTag cop was inspecting /Users/sue445/workspace/github.com/sue445/rubocop-isucon/lib/rubocop/cop/isucon/mysql2/n_plus_one_query.rb:51:8.
comparison of Integer with nil failed
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-yard-0.9.1/lib/rubocop/cop/yard/helper.rb:81:in `min'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-yard-0.9.1/lib/rubocop/cop/yard/helper.rb:81:in `build_docstring'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-yard-0.9.1/lib/rubocop/cop/yard/meaningless_tag.rb:38:in `check'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-yard-0.9.1/lib/rubocop/cop/yard/meaningless_tag.rb:29:in `on_class'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/cop/commissioner.rb:107:in `public_send'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/cop/commissioner.rb:107:in `block (2 levels) in trigger_responding_cops'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/cop/commissioner.rb:171:in `with_cop_error_handling'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/cop/commissioner.rb:106:in `block in trigger_responding_cops'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/cop/commissioner.rb:105:in `each'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/cop/commissioner.rb:105:in `trigger_responding_cops'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/cop/commissioner.rb:69:in `on_class'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-ast-1.30.0/lib/rubocop/ast/traversal.rb:138:in `on_while'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/cop/commissioner.rb:71:in `on_module'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-ast-1.30.0/lib/rubocop/ast/traversal.rb:138:in `on_while'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/cop/commissioner.rb:71:in `on_module'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-ast-1.30.0/lib/rubocop/ast/traversal.rb:138:in `on_while'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/cop/commissioner.rb:71:in `on_module'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-ast-1.30.0/lib/rubocop/ast/traversal.rb:138:in `on_while'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/cop/commissioner.rb:71:in `on_module'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-ast-1.30.0/lib/rubocop/ast/traversal.rb:20:in `walk'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/cop/commissioner.rb:87:in `investigate'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/cop/team.rb:156:in `investigate_partial'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/cop/team.rb:98:in `investigate'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/runner.rb:345:in `block in inspect_file'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/runner.rb:344:in `each'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/runner.rb:344:in `flat_map'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/runner.rb:344:in `inspect_file'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/runner.rb:287:in `block in do_inspection_loop'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/runner.rb:321:in `block in iterate_until_no_changes'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/runner.rb:314:in `loop'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/runner.rb:314:in `iterate_until_no_changes'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/runner.rb:283:in `do_inspection_loop'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/runner.rb:164:in `block in file_offenses'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/runner.rb:189:in `file_offense_cache'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/runner.rb:163:in `file_offenses'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/runner.rb:154:in `process_file'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/runner.rb:135:in `block in each_inspected_file'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/runner.rb:134:in `each'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/runner.rb:134:in `reduce'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/runner.rb:134:in `each_inspected_file'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/runner.rb:120:in `inspect_files'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/runner.rb:73:in `run'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/cli/command/execute_runner.rb:26:in `block in execute_runner'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/cli/command/execute_runner.rb:52:in `with_redirect'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/cli/command/execute_runner.rb:25:in `execute_runner'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/cli/command/execute_runner.rb:17:in `run'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/cli/command.rb:11:in `run'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/cli/environment.rb:18:in `run'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/cli.rb:118:in `run_command'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/cli.rb:125:in `execute_runners'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/cli.rb:51:in `block in run'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/cli.rb:77:in `profile_if_needed'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/lib/rubocop/cli.rb:43:in `run'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/exe/rubocop:19:in `block in <top (required)>'
/Users/sue445/.rbenv/versions/3.2.2/lib/ruby/3.2.0/benchmark.rb:311:in `realtime'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/gems/rubocop-1.58.0/exe/rubocop:19:in `<top (required)>'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/bin/rubocop:25:in `load'
/Users/sue445/workspace/github.com/sue445/rubocop-isucon/vendor/bundle/ruby/3.2.0/bin/rubocop:25:in `<top (required)>'
/Users/sue445/.rbenv/versions/3.2.2/lib/ruby/3.2.0/bundler/cli/exec.rb:58:in `load'
/Users/sue445/.rbenv/versions/3.2.2/lib/ruby/3.2.0/bundler/cli/exec.rb:58:in `kernel_load'
/Users/sue445/.rbenv/versions/3.2.2/lib/ruby/3.2.0/bundler/cli/exec.rb:23:in `run'
/Users/sue445/.rbenv/versions/3.2.2/lib/ruby/3.2.0/bundler/cli.rb:492:in `exec'
/Users/sue445/.rbenv/versions/3.2.2/lib/ruby/3.2.0/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
/Users/sue445/.rbenv/versions/3.2.2/lib/ruby/3.2.0/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
/Users/sue445/.rbenv/versions/3.2.2/lib/ruby/3.2.0/bundler/vendor/thor/lib/thor.rb:392:in `dispatch'
/Users/sue445/.rbenv/versions/3.2.2/lib/ruby/3.2.0/bundler/cli.rb:34:in `dispatch'
/Users/sue445/.rbenv/versions/3.2.2/lib/ruby/3.2.0/bundler/vendor/thor/lib/thor/base.rb:485:in `start'
/Users/sue445/.rbenv/versions/3.2.2/lib/ruby/3.2.0/bundler/cli.rb:28:in `start'
/Users/sue445/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/bundler-2.4.10/libexec/bundle:45:in `block in <top (required)>'
/Users/sue445/.rbenv/versions/3.2.2/lib/ruby/3.2.0/bundler/friendly_errors.rb:117:in `with_friendly_errors'
/Users/sue445/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/bundler-2.4.10/libexec/bundle:33:in `<top (required)>'
/Users/sue445/.rbenv/versions/3.2.2/bin/bundle:25:in `load'
/Users/sue445/.rbenv/versions/3.2.2/bin/bundle:25:in `<main>'
.

1 file inspected, no offenses detected

1 error occurred:
An error occurred while YARD/MeaninglessTag cop was inspecting /Users/sue445/workspace/github.com/sue445/rubocop-isucon/lib/rubocop/cop/isucon/mysql2/n_plus_one_query.rb:51:8.
Errors are usually caused by RuboCop bugs.
Please, report your problems to RuboCop's issue tracker.
https://github.com/rubocop/rubocop/issues

Mention the following information in the issue report:
1.58.0 (using Parser 3.2.2.4, rubocop-ast 1.30.0, running on ruby 3.2.2) [arm64-darwin22]
Finished in 0.1444899999999052 seconds

So I fixed this error.

ksss
ksss approved these changes Dec 9, 2023
View reviewed changes
Copy link
Owner

@ksss ksss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a great! Thank you!

@ksss ksss merged commit df2e68f into ksss:main Dec 9, 2023
3 checks passed
@ksss
Copy link
Owner

ksss commented Dec 9, 2023

v0.9.2 was out to the world ✨

@sue445 sue445 deleted the fix_meaning_less_error branch December 9, 2023 13:21
sue445 added a commit to sue445/rubocop-isucon that referenced this pull request Dec 9, 2023
@sue445
Requires rubocop-yard v0.9.2+
a8a55d2 
ref. ksss/rubocop-yard#23
@sue445 sue445 mentioned this pull request Dec 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksss ksss ksss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sue445 @ksss