-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-implement play mode #80
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
granawkins
commented
Jun 30, 2022
I appreciate the dual display mode, but your version of the read-out
just doesn't work for me. I can't "read" it. Maybe with color, bold,
spacing it will improve, but it looks like code, not a properly
formatted display.
…On 6/29/22 18:52, Grant wrote:
Re-implement a feature from Karoo Classic™: the (p)lay kernel (available in interactive mode). Loads a population of 1, prints it to the console and quits. Below is a sample output.
PS: We had a good discussion about the display last night. For now, play shows both display modes: 'viz' (the tree), then 'list'. We certainly will update these, but in a separate issue.
![karoo_play_mode](https://user-images.githubusercontent.com/50287275/176575539-be2dd2a7-7a94-438a-afde-a520090c2000.png)
You can view, comment on, or merge this pull request online at:
#80
-- Commit Summary --
* play mode
* fix play mode default tree_type to match menu (g)
-- File Changes --
M karoo-gp.py (23)
M karoo_gp/base_class.py (8)
M karoo_gp/engine.py (6)
-- Patch Links --
https://github.com/kstaats/karoo_gp/pull/80.patch
https://github.com/kstaats/karoo_gp/pull/80.diff
|
Message received! Just pushed a PR that looks like below. Will add color
with `click` in a future PR
<img width="662" alt="legible_display_list" src="https://user-images.githubusercontent.com/50287275/176804615-71169be9-50a0-4acf-8057-749ba5d9f8c5.png">
.
|
ezio-melotti
reviewed
Jul 2, 2022
ezio-melotti
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-implement a feature from Karoo Classic™: the (p)lay kernel (available in interactive mode). Loads a population of 1, prints it to the console and quits. Below is a sample output.
PS: We had a good discussion about the display last night. For now, play shows both display modes: 'viz' (the tree), then 'list'. We certainly will update these, but in a separate issue.