Added NULL check in ksmemory_notifyUnhandledFatalSignal for safety. (…

…#594)
kstenerud · Nov 19, 2024 · 14528ab · 14528ab
1 parent f66f0d4
commit 14528ab
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/Sources/KSCrashRecording/Monitors/KSCrashMonitor_Memory.m b/Sources/KSCrashRecording/Monitors/KSCrashMonitor_Memory.m
@@ -570,4 +570,9 @@ bool ksmemory_previous_session_was_terminated_due_to_memory(bool *userPerceptibl
 
 bool ksmemory_get_fatal_reports_enabled(void) { return g_FatalReportsEnabled; }
 
-void ksmemory_notifyUnhandledFatalSignal(void) { g_memory->fatal = true; }
+void ksmemory_notifyUnhandledFatalSignal(void)
+{
+    if (g_memory) {
+        g_memory->fatal = true;
+    }
+}
diff --git a/Tests/KSCrashRecordingTests/KSCrashMonitor_Memory_Tests.m b/Tests/KSCrashRecordingTests/KSCrashMonitor_Memory_Tests.m
@@ -313,4 +313,9 @@ - (void)testNonFatalReportLevel
     XCTAssertEqual(ksmemory_get_nonfatal_report_level(), KSCrashAppMemoryStateUrgent);
 }
 
+- (void)testNotifyUnhandledFatalSignal
+{
+    XCTAssertNoThrow(ksmemory_notifyUnhandledFatalSignal(), @"NULL safety for g_memory");
+}
+
 @end