Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.6.0 #33

Merged
merged 75 commits into from
Sep 30, 2024
Merged

v1.6.0 #33

merged 75 commits into from
Sep 30, 2024

Conversation

ktwrd
Copy link
Owner

@ktwrd ktwrd commented Sep 8, 2024

Breaking Changes

  • musl builds will be dropped since Repalce native-dialog with fltk #19 was merged and fltk-sys doesn't have good enough support for musl builds, so beans-rs will be referencing glibc (whatever version that the ubuntu-20.04 runner is using)

Additions

  • fltk will be used for dialogs to remove inconsistencies across systems. (Repalce native-dialog with fltk #19)
    • fltk will never be used when the --no-pause flag is present.
  • Added the ability to uninstall the targeted app (Uninstall Workflow #29)
    • Game must be closed for this to work, and an error message will show to the user if the game is already open. Checked with; crate::helper::is_game_running(String)
  • Added a progress bar for .tar.zstd extraction (Progress Bar for file extraction #32)
    • Note The decompressed size is estimated since you cannot get the decompressed zstd size without actually decompressing it (afaik, please correct me if I'm wrong)
  • Created specification for rustfmt (thx @toastxc for the help!)

@ktwrd ktwrd self-assigned this Sep 8, 2024
@ktwrd ktwrd requested a review from toastxc September 8, 2024 14:03
@ktwrd ktwrd changed the title v1.6.2 v1.6.0 Sep 8, 2024
@toastxc
Copy link
Collaborator

toastxc commented Sep 9, 2024

I'm happy to see musl go :3

@toastxc
Copy link
Collaborator

toastxc commented Sep 9, 2024

...It should be cleaned up a bit before merging
Mind if i?

@ktwrd
Copy link
Owner Author

ktwrd commented Sep 9, 2024

...It should be cleaned up a bit before merging
Mind if i?

Sure sounds good!

@ktwrd
Copy link
Owner Author

ktwrd commented Sep 9, 2024

I'm happy to see musl go :3

Same here, but I'm mainly concerned about server operators running weird distros that have ducky versions of glibc which works with the Source engine but not beans-rs

@toastxc
Copy link
Collaborator

toastxc commented Sep 9, 2024

We'll solve the edge cases when they appear ig.
retro-proofing is a fool's errand

@ktwrd
Copy link
Owner Author

ktwrd commented Sep 15, 2024

#34 must be merged before this PR can be.

@ktwrd
Copy link
Owner Author

ktwrd commented Sep 18, 2024

@toastxc merged #34, pls review and approve <3 /p

Show Current and Latest Version when an Update is available.
Copy link
Collaborator

@toastxc toastxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good! merging

@ktwrd ktwrd merged commit c9ec24d into main Sep 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants