Skip to content

Commit

Permalink
contest: vmksft-p: skip even if not ok
Browse files Browse the repository at this point in the history
KTAP is clear about the 'SKIP' directive and the result [1]:

> note the result of the test case result line can be either "ok" or
> "not ok" if the SKIP directive is used

Nothing seems to be imposed on TAP 13/14 side [2], so I suppose it is
fine.

We can then drop this restriction, and mark the test as 'skipped' if the
directive is starting with 'skip'.

Link: https://docs.kernel.org/dev-tools/ktap.html#test-case-result-lines [1]
Link: https://testanything.org/tap-version-14-specification.html [2]
Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
  • Loading branch information
matttbe authored and kuba-moo committed Aug 22, 2024
1 parent 51ae64e commit 506cfe8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion contest/remote/vmksft-p.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def _parse_nested_tests(full_run):
r = {'test': namify(v[3])}

if len(v) > 5 and v[4] and v[5]:
if v[5].lower().startswith('skip') and result == "pass":
if v[5].lower().startswith('skip'):
result = "skip"

t = time_re.findall(v[5].lower())
Expand Down

0 comments on commit 506cfe8

Please sign in to comment.