Do not put the Kubecost logo behind auth #3837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neal Ormsbee <[email protected]>
kaelanspatel
approved these changes
Feb 4, 2025
Merged
|
Agree, this is good for now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Prevents access to a logo used by the "auth failed" error page from becoming inaccessible due to...auth failing.
This is a wildly-overly-specific nginx location directive, but when I tried to use
/images/or/images, the image was still blocked by invalid auth. Maybe^/images/*$, or something, works. I'd need to read more about nginx. I think we'll want to revise the way our route handling is set up anyway.Does this PR rely on any other PRs?
No
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Prevent access to a logo used by the "auth failed" error page from becoming inaccessible due to...auth failing.
Links to Issues or tickets this PR addresses or fixes
What risks are associated with merging this PR? What is required to fully test this PR?
No real risk - I tested by seeing that the logo failed to load before the change, and afterward it loads fine.
How was this PR tested?
I tested by seeing that the logo failed to load before the change, and afterward it loads fine.
Have you made an update to documentation? If so, please provide the corresponding PR.
No.