Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): Created Snowflake data unload component #11349

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChaosEternal
Copy link

Added a component that talks to the snowflake database to do data unload to gcs bucket.

Copy link

Hi @ChaosEternal. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chensun
Copy link
Member

chensun commented Nov 1, 2024

@ChaosEternal can you please sign the DCO following: https://github.com/kubeflow/pipelines/pull/11349/checks?check_run_id=32381868852

Also this should be place under <repo_root>/components/snowflake, contrib folder is holding legacy components without active maintainers.

@chensun chensun requested review from chensun and removed request for neuromage and IronPan November 1, 2024 16:36
@chensun chensun self-assigned this Nov 1, 2024
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from chensun. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants