Add resource limit verification before adding memoryLimit to pods

Signed-off-by: Netanel Levine <[email protected]>
kubeflow · Jan 20, 2025 · d04eb62 · d04eb62
1 parent dfab4bb
commit d04eb62
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/internal/webhook/sparkpod_defaulter.go b/internal/webhook/sparkpod_defaulter.go
@@ -133,6 +133,10 @@ func addMemoryLimit(pod *corev1.Pod, app *v1beta2.SparkApplication) error {
 		return fmt.Errorf("failed to parse memory limit %s: %v", *memoryLimit, err)
 	}
 
+	if pod.Spec.Containers[i].Resources.Limits == nil {
+		pod.Spec.Containers[i].Resources.Limits = corev1.ResourceList{}
+	}
+
 	// Apply the memory limit to the container's resources
 	logger.Info(fmt.Sprintf("Adding memory limit %s to container in pod %s", *memoryLimit, pod.Name))
 	pod.Spec.Containers[i].Resources.Limits[corev1.ResourceMemory] = limitQuantity