Unit Tests for memoryLimit override feature #2389
Open
+126
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR includes Unit Tests for the features developed in #2383.
Proposed changes:
convertJavaMemoryStringToK8sMemoryString
addMemoryLimit
Change Category
Rationale
The most upvoted issue in the SparkOperator repository relates to having the ability to define different
memory
andmemoryLimits
values. The feature has been covered in #2383. I am adding unit tests to it to increase the trust in the code.Checklist
Additional Notes