fix reference to nil pointer (#3872)

Signed-off-by: zhangzujian <[email protected]>
kubeovn · Mar 27, 2024 · 07d1210 · 07d1210
1 parent 5b731b2
commit 07d1210
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/pkg/controller/init.go b/pkg/controller/init.go
@@ -622,15 +622,15 @@ func (c *Controller) syncSubnetCR() error {
 		klog.Error(err)
 		return err
 	}
-	for _, orisubnet := range subnets {
-		subnet := orisubnet.DeepCopy()
+	for _, cachedSubnet := range subnets {
+		subnet := cachedSubnet.DeepCopy()
 		if util.CheckProtocol(subnet.Spec.CIDRBlock) == kubeovnv1.ProtocolDual {
 			subnet, err = c.calcDualSubnetStatusIP(subnet)
 		} else {
 			subnet, err = c.calcSubnetStatusIP(subnet)
 		}
 		if err != nil {
-			klog.Errorf("failed to calculate subnet %s used ip: %v", subnet.Name, err)
+			klog.Errorf("failed to calculate subnet %s used ip: %v", cachedSubnet.Name, err)
 			return err
 		}
 

diff --git a/pkg/controller/subnet.go b/pkg/controller/subnet.go
@@ -746,7 +746,7 @@ func (c *Controller) handleAddOrUpdateSubnet(key string) error {
 		subnet, err = c.calcSubnetStatusIP(subnet)
 	}
 	if err != nil {
-		klog.Errorf("calculate subnet %s used ip failed, %v", subnet.Name, err)
+		klog.Errorf("calculate subnet %s used ip failed, %v", cachedSubnet.Name, err)
 		return err
 	}