fix IP residue after changing subnet of vm in some scenarios (#3370)

Signed-off-by: yuanliu <[email protected]>
kubeovn · Dec 16, 2023 · d30a4cf · d30a4cf
1 parent 407a26f
commit d30a4cf
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/pkg/controller/pod.go b/pkg/controller/pod.go
@@ -562,6 +562,12 @@ func (c *Controller) changeVMSubnet(vmName, namespace, providerName, subnetName
 	if ipCr != nil {
 		if ipCr.Spec.Subnet != subnetName {
 			key := fmt.Sprintf("%s/%s", pod.Namespace, vmName)
+			if err := c.config.KubeOvnClient.KubeovnV1().IPs().Delete(context.Background(), ipName, metav1.DeleteOptions{}); err != nil {
+				if !k8serrors.IsNotFound(err) {
+					klog.Errorf("failed to delete ip %s, %v", ipName, err)
+					return err
+				}
+			}
 			ports, err := c.ovnClient.ListPodLogicalSwitchPorts(key)
 			if err != nil {
 				klog.Errorf("failed to list lsps of pod '%s', %v", pod.Name, err)
@@ -575,6 +581,7 @@ func (c *Controller) changeVMSubnet(vmName, namespace, providerName, subnetName
 					return err
 				}
 			}
+			c.ipam.ReleaseAddressByPod(key, subnetName)
 		}
 	}
 	return nil