fix: lsp define in nb is not clear when delete vm #3429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobz965
approved these changes
Nov 16, 2023
watermelon-brother
force-pushed
the
clear-lsp-when-delete-vm
branch
from
3ccdd7e
to
309810b
Compare
hongzhen-ma
requested changes
Nov 17, 2023
pkg/controller/pod.go
Outdated
| ports, err := c.OVNNbClient.ListNormalLogicalSwitchPorts(true, map[string]string{"pod": key}) | ||
| isVMPod, vmName := isVMPod(pod) | ||
| podkey := key | ||
| if isVMPod { |
There was a problem hiding this comment.
在设置 keep-vm-ip 参数的情况下，可以使用 vm name 作为 key 查找 lsp
如果没有设置该参数，vm pod 的 lsp name 仍然为 pod name 构成。
因此需要添加 c.config.EnableKeepVMIP 参数判断
There was a problem hiding this comment.
pod ipam release 也需要修改下名字
watermelon-brother
force-pushed
the
clear-lsp-when-delete-vm
branch
2 times, most recently
from
b007604
to
b94aa09
Compare
zhangzujian
force-pushed
the
clear-lsp-when-delete-vm
branch
from
b94aa09
to
653e587
Compare
Signed-off-by: wujixin <[email protected]>
zhangzujian
force-pushed
the
clear-lsp-when-delete-vm
branch
from
653e587
to
1e45f27
Compare
bobz965
reviewed
Nov 28, 2023
| ports, err := c.OVNNbClient.ListNormalLogicalSwitchPorts(true, map[string]string{"pod": key}) | ||
| isVMPod, vmName := isVMPod(pod) | ||
| isVMPodNeedKeepIP := isVMPod && c.config.EnableKeepVMIP | ||
| podkey := key |
There was a problem hiding this comment.
后面的 c.ipam.ReleaseAddressByPod(key) 应该也有问题
|
pr #3476 has fixed this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
fix: lsp define in nb is not clear when delete vm
Which issue(s) this PR fixes
#3424
WHAT
If lsp define in nb is not clear, only gc run can clear it.
HOW
we can think the pod is vm or normal pod when add some logic.