fix: apply changes to the latest version #3514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobz965
requested changes
Dec 12, 2023
bobz965
requested changes
Dec 12, 2023
bobz965
approved these changes
Dec 12, 2023
|
hi @oilbeater could you help review this? thanks |
Signed-off-by: zcq98 <[email protected]>
oilbeater
requested changes
Dec 19, 2023
oilbeater
approved these changes
Dec 19, 2023
|
Nice catch! @zcq98 |
bobz965
pushed a commit
that referenced
this pull request
Dec 19, 2023
Signed-off-by: zcq98 <[email protected]> Co-authored-by: zcq98 <[email protected]>
oilbeater
pushed a commit
that referenced
this pull request
Dec 20, 2023
Signed-off-by: zcq98 <[email protected]> Co-authored-by: zcq98 <[email protected]> Signed-off-by: oilbeater <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
c.config.KubeOvnClient.KubeovnV1().Subnets().Update should be applied on the latest subnet, func formatSubnet should return the latest version subnet（same problem to vlan and vpc update）
Which issue(s) this PR fixes
WHAT
🤖[deprecated] Generated by Copilot at 4f0444f
Refactor and optimize some functions related to subnet, vlan, vpc, and vip initialization and status update in
pkg/controller. Reduce unnecessary deep copies and controller arguments, and make the functions return updated objects. Use theUpdatemethod instead of the deprecatedPatchSyncmethod in the e2e test.🤖[deprecated] Generated by Copilot at 4f0444f
HOW
🤖[deprecated] Generated by Copilot at 4f0444f
formatSubnet,calcDualSubnetStatusIP, andcalcSubnetStatusIPfunctions to methods of theControllerstruct and remove thecparameter (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link). This makes the code more consistent and concise, and avoids passing the controller as an argument to every function that needs it.