Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: fix clab bgp cleanup #3524

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented Dec 14, 2023

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

Fixes #(issue-number)

WHAT

🤖[deprecated] Generated by Copilot at ce35fa3

Improved the Makefile to support BGP testing with container lab. Fixed volume mount paths and added make targets for clab-bgp and clab-bgp-ha scenarios.

🤖[deprecated] Generated by Copilot at ce35fa3

Sing, O Muse, of the skillful coder who changed the paths
Of the volume mounts for clab-bgp and clab-bgp-ha, files of power
To avoid the strife of conflicts and match the commands of clab
The tool of many wonders, that creates and destroys container labs

HOW

🤖[deprecated] Generated by Copilot at ce35fa3

  • Change volume mount paths and commands for clab-bgp.yaml and clab-bgp-ha.yaml files to avoid conflicts with other clab files (link, link, link, link)
  • Add support for BGP peering with external routers in a container lab environment using clab-bgp.yaml and clab-bgp-ha.yaml files (link, link)
  • Add a make target to clean up the container lab environment for BGP peering with external routers using clab destroy command (link, link)

@zhangzujian zhangzujian merged commit 508535a into kubeovn:master Dec 14, 2023
57 of 58 checks passed
@zhangzujian zhangzujian deleted the fix-clab-bgp branch December 14, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants