Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller: fix gateway nodes check #4912

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhangzujian
Copy link
Member

  1. skip subnets in custom vpcs;
  2. skip join subnet;
  3. remove duplicate logic in checkPolicyRouteExistForNode().

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

Fixes #(issue-number)

@coveralls
Copy link

coveralls commented Jan 9, 2025

Pull Request Test Coverage Report for Build 12723297760

Details

  • 0 of 16 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 22.06%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller/node.go 0 16 0.0%
Totals Coverage Status
Change from base Build 12723274642: 0.006%
Covered Lines: 10164
Relevant Lines: 46075

💛 - Coveralls

@zhangzujian zhangzujian marked this pull request as ready for review January 10, 2025 08:44
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 10, 2025
@zhangzujian zhangzujian marked this pull request as draft January 10, 2025 08:44
@dosubot dosubot bot added the bug Something isn't working label Jan 10, 2025
1. skip subnets in custom vpcs;
2. skip join subnet;
3. remove duplicate logic in checkPolicyRouteExistForNode().

Signed-off-by: zhangzujian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants